Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suit: move CoAP endpoints to the example #21045

Merged
merged 1 commit into from
Nov 27, 2024
Merged

suit: move CoAP endpoints to the example #21045

merged 1 commit into from
Nov 27, 2024

Conversation

benpicco
Copy link
Contributor

Contribution description

Those endpoints are very specific to the example and not useful for general use.
(We don't want an endpoint where we post the Manifest URL to, if we want to post anything, it'd be the manifest)

Move them to the example's CoAP endpoints to avoid confusing users.

Testing procedure

The example does behave just as before.

main(): This is RIOT! (Version: 2025.01-devel-207-g83569-suit/coap_endpoints)
RIOT SUIT update example application
Running from slot 0
Image magic_number: 0x544f4952
Image Version: 0x00000000
Image start address: 0x00001100
Header chksum: 0x7f7aaea1

Starting the shell
> suit: received URL: "coap://[2001:db8::1]/fw/suit_update/samr34-xpro/riot.suit.latest.bin"
suit_worker: started.
suit_worker: downloading "coap://[2001:db8::1]/fw/suit_update/samr34-xpro/riot.suit.latest.bin"
suit_worker: got manifest with size 485
suit: verifying manifest signature
suit: validated manifest version
Manifest seq_no: 1732626752, highest available: 0
suit: validated sequence number
Formatted component name: 
Comparing manifest offset 1000 with other slot offset
Comparing manifest offset 20800 with other slot offset
validating vendor ID
Comparing 547d0d74-6d3a-5a92-9662-4881afd9407b to 547d0d74-6d3a-5a92-9662-4881afd9407b from manifest
validating vendor ID: OK
validating class id
Comparing 6421399d-f53c-5d59-8534-b04659463f70 to 6421399d-f53c-5d59-8534-b04659463f70 from manifest
validating class id: OK
Comparing manifest offset 1000 with other slot offset
Comparing manifest offset 20800 with other slot offset
SUIT policy check OK.
Formatted component name: 
riotboot_flashwrite: initializing update to target slot 1
Fetching firmware |█████████████████████████| 100%
Finalizing payload store
Verifying image digest
Starting digest verification against image
Install correct payload
Verified installed payload
Verifying image digest
Starting digest verification against image
Verified installed payload
Image magic_number: 0x544f4952
Image Version: 0x6745c940
Image start address: 0x00020900
Header chksum: 0xca4fd729

suit_worker: update successful

Issues/PRs references

@benpicco
suit: move CoAP endpoints to the example
83569aa 
Those endpoints are very specific to the example and not
useful for general use.

Move them to the example's CoAP endpoints.
@github-actions github-actions bot added Area: OTA Area: Over-the-air updates Area: sys Area: System Area: examples Area: Example Applications labels Nov 26, 2024
@benpicco benpicco requested review from chrysn and maribu November 26, 2024 18:56
@benpicco benpicco added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 26, 2024
@riot-ci
Copy link

riot-ci commented Nov 26, 2024

Murdock results

✔️ PASSED

83569aa suit: move CoAP endpoints to the example

Success Failures Total Runtime
10249 0 10249 15m:23s

Artifacts

@benpicco benpicco added this pull request to the merge queue Nov 26, 2024
Merged via the queue into RIOT-OS:master with commit 6f3f425 Nov 27, 2024
28 checks passed
@benpicco benpicco deleted the suit/coap_endpoints branch November 27, 2024 10:04
@MrKevinWeiss MrKevinWeiss added this to the Release 2025.01 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

@bergzand bergzand Awaiting requested review from bergzand bergzand is a code owner

@chrysn chrysn Awaiting requested review from chrysn

Assignees
No one assigned
Labels
Area: examples Area: Example Applications Area: OTA Area: Over-the-air updates Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2025.01
Development

Successfully merging this pull request may close these issues.
4 participants
@benpicco @riot-ci @maribu @MrKevinWeiss